fix(jsdom): support AbortSignal API#8704
Merged
sheremet-va merged 3 commits intovitest-dev:mainfrom Oct 14, 2025
Merged
Conversation
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
reviewed
Oct 14, 2025
| }) | ||
| const clearWindowErrors = catchWindowErrors(dom.window as any) | ||
|
|
||
| patchAddEventListener(dom.window) |
Contributor
There was a problem hiding this comment.
Shouldn't this unpatch on teardown?
Member
Author
There was a problem hiding this comment.
teardown removes the EventTarget from global so I don't think it needs to be unpatched
Contributor
There was a problem hiding this comment.
Right, I wondered about that, but just in case? I'm fine either way.
Member
Author
There was a problem hiding this comment.
Ok, let's add it just in case
hi-ogawa
previously approved these changes
Oct 14, 2025
| }) | ||
| const clearWindowErrors = catchWindowErrors(dom.window as any) | ||
|
|
||
| patchAddEventListener(dom.window) |
Contributor
There was a problem hiding this comment.
Right, I wondered about that, but just in case? I'm fine either way.
AriPerkkio
previously approved these changes
Oct 14, 2025
Member
AriPerkkio
left a comment
AriPerkkio
left a comment
There was a problem hiding this comment.
Looks good. Patching globals just for JSDOM is fine as it's already simulating so much.
This was referenced Nov 3, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8563
In jsdom
AbortSignalAPI is used only inaddEventListener.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.